[Infra UI][Stack Monitoring] Migrate EuiPage*_Depracated usage #161870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
crespocarlos
added
chore
Feature:Metrics UI
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
crespocarlos
changed the title
There was a problem hiding this comment.
It is looking the same as edge 👍. For the stack monitoring changes I compared with the monitoring cluster and in the local version, I see a scroll bar even if there is less content:
| Local | Monitoring Cluster |
|---|---|
 |
 |
Is that something changed here or it's not related 🤔
| </EuiCallOut> | ||
| </EuiPageTemplate.Section> | ||
| </EuiPageTemplate> | ||
| // <EuiPage style={{ flex: '1 0 auto' }}> |
Good catch! I didn't test it on my big screen. Fixing it :) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
jennypavlova
approved these changes
Jul 18, 2023
boriskirov
approved these changes
Jul 20, 2023
…euipage_deprecated_usage
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
1 task
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…ic#161870) closes [elastic#161404](elastic#161404) ## Summary This PR replaces the usage of `EuiPage*_Depracated` with their equivalent components Some usages of `EuiPageContent_Deprecated` have been replaced with `EuiPanel` because they were displayed as panels, and the recommended `EuiPageSection` component did not render in the same manner. e.g: <img width="1690" alt="image" src="https://github.com/elastic/kibana/assets/2767137/b86db831-e79e-4be0-918f-f3b25803e990"> code: https://github.com/elastic/kibana/pull/161870/files#diff-72520cac696197524aff32e2b92a0acabe1898067c6985786fa5ac250a40ac1cR122 ### How to test - Start a local Kibana with metricbeat monitoring Beats, Kibana, Elasticsearch and Logstash - Navigate to Stack Monitoring and click through the links - Compare the UI (loading and error states included) with what's currently in https://edge-oblt.kb.us-west2.gcp.elastic-cloud.com/ - Navigate to Infra UI and go to node details - Compare the UI (loading and error states included) with what's currently in https://edge-oblt.kb.us-west2.gcp.elastic-cloud.com/ --------- Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #161404
Summary
This PR replaces the usage of
EuiPage*_Depracatedwith their equivalent componentsSome usages of
EuiPageContent_Deprecatedhave been replaced withEuiPanelbecause they were displayed as panels, and the recommendedEuiPageSectioncomponent did not render in the same manner. e.g:code: https://github.com/elastic/kibana/pull/161870/files#diff-72520cac696197524aff32e2b92a0acabe1898067c6985786fa5ac250a40ac1cR122
How to test